chore: add assert for dtensor v2 cpu offload#1817
Merged
Conversation
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Contributor
📝 WalkthroughWalkthroughModified environment configuration for non-colocated generation by setting NCCL_CUMEM_ENABLE, and added validation to prevent CPU offload usage on single-GPU environments during distributed setup initialization. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@nemo_rl/models/automodel/setup.py`:
- Around line 286-290: The NotImplementedError raised when cpu_offload is True
contains an incorrect GitHub URL; update the error message in the cpu_offload
guard (the NotImplementedError raised near cpu_offload and before
_setup_distributed()) to point to the correct repository URL (e.g.,
https://github.com/NVIDIA-NeMo/RL or the canonical
https://github.com/NVIDIA/NeMo) so the message directs users to the right issue
tracker.
RayenTian
added a commit
that referenced
this pull request
Jan 26, 2026
Signed-off-by: ruit <ruit@nvidia.com>
RayenTian
added a commit
that referenced
this pull request
Jan 28, 2026
Signed-off-by: ruit <ruit@nvidia.com>
hemildesai
approved these changes
Jan 29, 2026
terrykong
approved these changes
Jan 29, 2026
RayenTian
added a commit
that referenced
this pull request
Feb 2, 2026
Signed-off-by: ruit <ruit@nvidia.com>
yuanhangsu1986
pushed a commit
to yuanhangsu1986/RL-Nemontron-Edge-Omni
that referenced
this pull request
Feb 12, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986
pushed a commit
to yuanhangsu1986/RL-Nemontron-Edge-Omni
that referenced
this pull request
Feb 21, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 8, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 8, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 9, 2026
Signed-off-by: Yuki Huang <yukih@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For world size 1, FSDP uses extra memory which is not necessary, so AutoModel disable it for now. This PR add an assert for it.
Summary by CodeRabbit
Bug Fixes
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.